Add reporting year to salary percentile queries, handles #548 - Githubissues

datamade / bga-payroll

💰 How much do your public officials make?

4 stars 4 forks source link

Add reporting year to salary percentile queries, handles #548 #549

Closed hancush closed 2 years ago

hancush commented 2 years ago

Description

This PR:

Adds a reporting_year property to the VintagedModel, to make year easily accessible
Calculates employer percentiles across salaries limited to the relevant reporting year
Removes the deprecated of_employer method from Salary

Testing instructions

Confirm CI passes.
Once approved, merge to master to deploy to staging.
View the person referenced in #548 and confirm her salary percentile now makes sense.
View employee/s of a classified employer, e.g., a police department, and confirm those percentiles make sense.