datamade / bga-payroll

💰 How much do your public officials make?
4 stars 4 forks source link

Phantom agency #553

Open deraj1013 opened 2 years ago

deraj1013 commented 2 years ago

Didn't know what else to call it, but I updated the Deerfield-Bannockburn FPD so that there was a hyphen in it. The last version was uploaded without it and wouldn't link to past years. I updated it, but for some reason both agencies are in there even though the non-hyphen version was not in the raw data. https://bga-payroll.datamade.us/unit/deerfield-bannockburn-fpd-7c7add7f/?data_year=201

Screen Shot 2021-10-27 at 1 21 05 PM

9

hancush commented 2 years ago

Thanks for the catch, @deraj1013. Can you provide a list of agencies whose name changed in the amended upload? I will need to manually remove them.

deraj1013 commented 2 years ago

Sure - I'll have to put it together as I run through them. Alsip was uploaded as Alisp because I have fat fingers and I type like a chump. I'll add any others as I think of them.

hancush commented 2 years ago

Thanks – let me know when you have a final list and I'll remove them in one fell swoop.

deraj1013 commented 2 years ago

I'm about 25% through the agency updates from the file. I'll keep pasting here as I find them.

hancush commented 2 years ago

Awesome. Even if we don't prioritize a full self-service import next go-round, if it happens relatively frequently that there's a typo or small formatting thing that causes agencies to be distinct from previous years, I think it would be a good investment to update the employer editing interface to let you fix the employer name so it matches the previous year and combines the data without having to do a full reupload.

deraj1013 commented 2 years ago

Also on the list: Warren Newport Library District, Green Garden Townshship, La Grange Library District, La Grange Park Library District (updated in the latest version, not currently on site) in addition to Deerfield Bannockburn FPD.

hancush commented 2 years ago

Checklist:

hancush commented 2 years ago

@deraj1013 Have nixed all but one of the specified agencies. Wanted to touch base on Warren Newport. Looks like Warren Newport Library District has data for all three years, while the hyphenated version only has 2019.

Which version do you want to preserve?

deraj1013 commented 2 years ago

I want the one with three years linked ... so we would lose the hyphenated one.

hancush commented 2 years ago

Roger that, @deraj1013, thank you for the quick response!

deraj1013 commented 2 years ago

Found another one to eliminate: Homewood-Flossomoor Park District. The unhyphenated version (Homewood Flossomoor Park District) links to the past versions, and the hyphenated version is an orphan.

hancush commented 2 years ago

Hyphenated Homewood-Flossomoor Park District has been eliminated.