datamade / bga-payroll

💰 How much do your public officials make?
4 stars 4 forks source link

Unit/department not populated correctly when downloading data from unit page #564

Closed hancush closed 2 years ago

hancush commented 2 years ago

Replicated for a couple of units:

Cook County

Screen Shot 2021-11-16 at 8 18 12 AM

Cook County SD 130

Screen Shot 2021-11-16 at 8 17 49 AM

Downloading data from the department page seems to behave correctly (unit in unit column, department in department column).

fgregg commented 2 years ago

What is the expected behavior for top level units

name unit department
Karina, Alatorre Cook County SD 130 Cook County SD 130

or

name unit department
Karina, Alatorre Cook County SD 130
fgregg commented 2 years ago

@hancush could you let us know what the correct thing is here?

hancush commented 2 years ago

SD was a bad example because it doesn't have departments. This is more a problem for units like Cook County, which does have departments, which are not reflected in the export.

For units with departments:

name unit department
Name Cook County e.g., Stroger Hospital Of Cook Cnty

For direct employees of a unit, my preference would be the following but I don't think it's a big deal if it's easier to just duplicate the unit name as the department:

name unit department
Karina, Alatorre Cook County SD 130
fgregg commented 2 years ago

okay, thanks!