search

datamade / django-councilmatic-notifications

Notifications app for Django Councilmatic
MIT License
1 stars 0 forks source link

Sending me the same "new" stuff every day. #3

Open fgregg opened 7 years ago

fgregg commented 7 years ago

This is still happening.

reginafcompton commented 7 years ago

I changed the crontab to run the correct import_data command. You should receive a new email or no email tomorrow.

fgregg commented 7 years ago

why don't you set the crontab so we can test it now.

On Wed, Dec 28, 2016 at 3:59 PM, Regina Compton notifications@github.com wrote:

I changed the crontab to run the correct import_data command. You should receive a new email or no email tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic-notifications/issues/3#issuecomment-269547806, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxbX_kaDvax67NQ61-wgSzaFPRDPBoks5rMtvPgaJpZM4LEcrJ .

-- 773.888.2718

reginafcompton commented 7 years ago

@fgregg Okay. Let me know if you do or do not get an email at 4:50 pm today.

fgregg commented 7 years ago

I still don't understand how a cronjob could be responsible for sending me the same information every day. Could you explain that, please?

On Wed, Dec 28, 2016 at 4:36 PM, Regina Compton notifications@github.com wrote:

@fgregg https://github.com/fgregg Okay. Let me know if you do or do not get an email at 4:50 pm today.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic-notifications/issues/3#issuecomment-269552208, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxbY9gyPQY0Ke3UhcVeuEMUvz4_1J1ks5rMuRRgaJpZM4LEcrJ .

-- 773.888.2718

reginafcompton commented 7 years ago

Of course. The later releases of django-councilmatic use "import_data" as the management command. The cronjob for the nyc-councilmatic staging site (which requires the latest version of django-councilmatic) was still calling "loaddata," so new data was never loaded....hence you were getting emails with the same content everyday.

Sent from my iPhone

On Dec 28, 2016, at 5:49 PM, Forest Gregg notifications@github.com wrote:

I still don't understand how a cronjob could be responsible for sending me the same information every day. Could you explain that, please?

On Wed, Dec 28, 2016 at 4:36 PM, Regina Compton notifications@github.com wrote:

@fgregg https://github.com/fgregg Okay. Let me know if you do or do not get an email at 4:50 pm today.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic-notifications/issues/3#issuecomment-269552208, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxbY9gyPQY0Ke3UhcVeuEMUvz4_1J1ks5rMuRRgaJpZM4LEcrJ .

-- 773.888.2718 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

fgregg commented 7 years ago

Some days there won't be any new data that gets loaded, I still shouldn't get the same e-mail that I got yesterday. I don't understand how your changes prevent that.

On Wed, Dec 28, 2016 at 8:57 PM, Regina Compton notifications@github.com wrote:

Of course. The later releases of django-councilmatic use "import_data" as the management command. The cronjob for the nyc-councilmatic staging site (which requires the latest version of django-councilmatic) was still calling "loaddata," so new data was never loaded....hence you were getting emails with the same content everyday.

Sent from my iPhone

On Dec 28, 2016, at 5:49 PM, Forest Gregg notifications@github.com wrote:

I still don't understand how a cronjob could be responsible for sending me the same information every day. Could you explain that, please?

On Wed, Dec 28, 2016 at 4:36 PM, Regina Compton < notifications@github.com> wrote:

@fgregg https://github.com/fgregg Okay. Let me know if you do or do not get an email at 4:50 pm today.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic- notifications/issues/3#issuecomment-269552208, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAgxbY9gyPQY0Ke3UhcVeuEMUvz4_1J1ks5rMuRRgaJpZM4LEcrJ .

-- 773.888.2718 <(773)%20888-2718> — You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic-notifications/issues/3#issuecomment-269574899, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxbUzrjZqu0c9ZaFk9LIBIqj9V7Voyks5rMyGMgaJpZM4LEcrJ .

-- 773.888.2718

reginafcompton commented 7 years ago

We now have a new_actions table, which the send_notifications management command relies upon to find out what's new. If the import_data command never runs, then this table never changes. The cronjob, though it did not call import_data, did call send_notifications, so you kept getting the same email based on the content of the never-up-to-date new_actions table.

Sent from my iPhone

On Dec 28, 2016, at 9:13 PM, Forest Gregg notifications@github.com wrote:

Some days there won't be any new data that gets loaded, I still shouldn't get the same e-mail that I got yesterday. I don't understand how your changes prevent that.

On Wed, Dec 28, 2016 at 8:57 PM, Regina Compton notifications@github.com wrote:

Of course. The later releases of django-councilmatic use "import_data" as the management command. The cronjob for the nyc-councilmatic staging site (which requires the latest version of django-councilmatic) was still calling "loaddata," so new data was never loaded....hence you were getting emails with the same content everyday.

Sent from my iPhone

On Dec 28, 2016, at 5:49 PM, Forest Gregg notifications@github.com wrote:

I still don't understand how a cronjob could be responsible for sending me the same information every day. Could you explain that, please?

On Wed, Dec 28, 2016 at 4:36 PM, Regina Compton < notifications@github.com> wrote:

@fgregg https://github.com/fgregg Okay. Let me know if you do or do not get an email at 4:50 pm today.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic- notifications/issues/3#issuecomment-269552208, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAgxbY9gyPQY0Ke3UhcVeuEMUvz4_1J1ks5rMuRRgaJpZM4LEcrJ .

-- 773.888.2718 <(773)%20888-2718> — You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datamade/django-councilmatic-notifications/issues/3#issuecomment-269574899, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgxbUzrjZqu0c9ZaFk9LIBIqj9V7Voyks5rMyGMgaJpZM4LEcrJ .

-- 773.888.2718 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.