search

datamade / django-councilmatic

:heartpulse: Django app providing core functions for *.councilmatic.org
http://councilmatic.org
MIT License
26 stars 16 forks source link

Make update_since an instance attribute #243

Closed hancush closed 5 years ago

hancush commented 5 years ago

Attributes defined at the class level should be immutable, as a whole class of mysterious bugs occurs when a class attribute is changed.

This PR defines update_since in the handle method, instead of at the class-level, because we do indeed update it sometimes.

hancush commented 5 years ago

Tests will pass once https://github.com/datamade/django-councilmatic-notifications/pull/31 is brought in.