datamade / django-councilmatic

:heartpulse: Django app providing core functions for *.councilmatic.org
http://councilmatic.org
MIT License
26 stars 16 forks source link

XSS Vulnerability when using filter options #270

Open Krazian opened 4 years ago

Krazian commented 4 years ago

This issue happens for all cities that use your product. Within the /search view, you can use the filter parameters to run Javascript code in an HTML script tag. See the following for an example:

I attempted to do the same on http://philly.councilmatic.org/, but it ended up breaking and showing a Heroku error.

jeancochrane commented 4 years ago

Thanks very much for reporting this vulnerability. We've got a fix open in https://github.com/datamade/django-councilmatic/pull/271 and will update this issue as soon as we've patched production systems.

jeancochrane commented 4 years ago

We released 2.5.9 to fix this bug. The fix is currently being rolled out to LA Metro, and we're working on logistics to do it for Chicago and New York as well.