datamade / django-councilmatic

:heartpulse: Django app providing core functions for *.councilmatic.org
http://councilmatic.org
MIT License
26 stars 16 forks source link

Cast bill action dates to date objects, not date time objects #272

Closed hancush closed 4 years ago

hancush commented 4 years ago

Description

Bill action dates come to us as date strings. Originally, we cast them to date times, but this caused issues, as described in https://github.com/datamade/la-metro-councilmatic/issues/638.

This PR:

We should treat this as a breaking change, in case downstream instances do anything with the last action date, e.g., in the Chicago search index definition.

Also, we should do this for memberships, too, but I want to do that separately for the sake of a neat diff and an expedient fix for action dates, which are displayed in lots of places, now. Opened #273 to track that work.

Testing instructions

N.b., I've already done this.