search

datamade / django-councilmatic

:heartpulse: Django app providing core functions for *.councilmatic.org
http://councilmatic.org
MIT License
26 stars 16 forks source link

Added flake8 travis tests and badge #57

Closed patcon closed 8 years ago

patcon commented 8 years ago

No corrections so far, in case there are some we don't care about. So far, just ignoring the max line length.

If I find a good tool to auto-correct the issues, i might send a PR before I hear back which rules we're interested in enforcing :)

patcon commented 8 years ago

Used autopep8 to correct a bunch of things, then manually addressed the others. Ignoring line length checks, and also ignoring a check related to lambda's, which seemed a bit invasive.

The tests should pass as-is, and this is ready for review when you get time

patcon commented 8 years ago

all your rebase are belong to us

patcon commented 8 years ago

OK, not sure if it was causing problems, but seemed that we weren't actually editting the context object, but were instead returning a fresh dict for IndexView, unlike the other views. Seems there was no consequence, but for consistency, we're now merging the generated dict into it, and returning the whole shbang :)

(Only modified the final bugfix commit.)

cathydeng commented 8 years ago

ok, testing this out & everything looks fine. wana add a sentence to the readme (maybe another bonus point in the pull requests section) on using flake8 to check styling when contributing code?

patcon commented 8 years ago

Thanks! Done and done :)

cathydeng commented 8 years ago

cool, looks good. I don't wana be too strict about styling & require all new folks to adhere to pep8 guidelines in order to contribute, but I'll just make those changes to the readme

patcon commented 8 years ago

:+1: I'm sure they're voluntarily become style-junkies when pesky little X's start showing up in their PRs -- no hassling required on your part :)