datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
84 stars 12 forks source link

s/run lint/run test in Gatsby template README #154

Closed hancush closed 3 years ago

hancush commented 3 years ago

Description

The command to run the linter is test

https://github.com/datamade/how-to/blob/51c7f4804026388bbe5517119eda73c6344d3248/docker/templates/new-gatsby-app/%7B%7Bcookiecutter.app_name%7D%7D/package.json#L41

– but our README says lint

https://github.com/datamade/how-to/blob/master/docker/templates/new-gatsby-app/%7B%7Bcookiecutter.app_name%7D%7D/README.md#testing

We should fix this!

Kudos to @derekeder for catching this: https://github.com/sunrisedatadept/green-jobs/pull/34/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

derekeder commented 3 years ago

oh yah - thanks for opening this!