search

datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
88 stars 12 forks source link

Default to wait on CI for Heroku deployments #169

Closed hancush closed 3 years ago

fgregg commented 3 years ago

is this a setting we can set in: https://github.com/datamade/how-to/blob/master/docker/templates/new-django-app/%7B%7Bcookiecutter.app_name%7D%7D/heroku.yml

fgregg commented 3 years ago

do we also want this for linting and testing for netlify deployments that are javacript-y

hancush commented 3 years ago

Netlify does not offer a checkbox to wait for CI like Heroku. Seems like their recommended approach is to trigger a deployment from the GitHub Action (similarly to how we do with CodeDeploy): https://answers.netlify.com/t/quick-question-about-ci-interaction-and-deploys-from-github/26986/2

If this is a path we want to go down, Netlify maintains a small suite of simple actions we could integrate: https://github.com/netlify/actions

I'd love if someone else could pick up a spike of this! (Alternatives also welcome.)

hancush commented 3 years ago

Given that we run CI against PRs, I think this is probably low priority in the grand scheme of things. The redundancy reminds me of #153.