search

datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
81 stars 12 forks source link

Add github-action docker image building to our cookie cutters. #224

Closed fgregg closed 2 years ago

fgregg commented 2 years ago

Let's add a github action template for building and publishing docker images to our cookie cutter templates. Something along the line of https://github.com/fgregg/knoxville_utility_burden/blob/main/.github/workflows/publish_docker.yml

Not sure if this is the right place for this @hancush.

hancush commented 2 years ago

Related to #153.

hancush commented 2 years ago

@fgregg will add this to the new-django-app and python-docker-env cookiecutters.

hancush commented 2 years ago

The exact pattern in Knoxville Utility Burden didn't work for me, but this adaption of the v2 action did: https://github.com/datamade/councilmatic-document-merger/blob/main/.github/workflows/publish_image.yml

hancush commented 2 years ago

I've implemented this for Metro and the OCD scrapers. We've also transitioned to using the image from master for Metro development, anecdotally an improvement!