search

datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
81 stars 12 forks source link

Django translation on Heroku #225

Closed derekeder closed 1 year ago

derekeder commented 2 years ago

Documentation request

While setting up translations for the Arts Census website, I ran into an issue with storing compiled .mo translation files on Heroku: https://github.com/datamade/arts-census/pull/68

We should update our documentation in https://github.com/datamade/how-to/blob/master/django/translation.md to reflect this

derekeder commented 2 years ago

Upon revisiting the documentation, I think my approach in datamade/arts-census#68 feels a bit hacky and incomplete, as I opted to not use Rosetta.

On the next project where we'll need to do translation on a Django/Heroku site with Rosetta, we should take a fresh look at this documentation and update as necessary. We may still need to commit the .mo files, but I'm unsure what the impact this will have on Rosetta.

hancush commented 2 years ago

Will be trialing on EFI.

derekeder commented 1 year ago

Followed this same approach for EFI: https://github.com/datamade/mpc-efi/pull/81

@antidipyramid and I are looking into the best approach to extend translation to the React components of the site and will have a follow-up PR for that.