datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
80 stars 12 forks source link

Add custom Bootstrap build setup to the Django and Wagtail templates #308

Open hancush opened 1 year ago

hancush commented 1 year ago

Documentation request

It's easy to use Sass to customize the look and feel of Bootstrap, but it's not always easy to set up. Bake scaffolding into our templates, including a custom Sass file, develop script, and README instructions.

Example PRs:

smcalilly commented 1 year ago

@fatima3558 i'm going to update bootstrap via #278, will that cause any problems with this work?

hancush commented 1 year ago

@smcalilly Bootstrap 5 is not compatible with IE. Think we want to stick with 4.

smcalilly commented 1 year ago

@hancush Do we still need to support IE? They retired it last summer and started removing it from existing Windows 10 distros.

smcalilly commented 1 year ago

I'm curious about the access to technology and equity ramifications that we'd incur by not supporting IE, that's the only reason I can think of where we'd need to continue that support. Maybe we can look at Google Analytics data for some of our sites to see if it's still used.

hancush commented 1 year ago

Good point. We had a whopping 3 visits to ChiBlockBuilder from IE since we set up Matomo. Paging @derekeder on this, as well. In the past, I've defended IE because of our government clients, who tend to have less control over the browsers available to them on their work machines. Do we still need to support it in 2023?

smcalilly commented 1 year ago

Yeah I've felt the same way about IE even though it's difficult from a developer perspective. When I saw that news about them disabling it, I thought that was a signal that we no longer had to support it but haven't done much research about it.

This blog post argues that it might be good for accessibility: https://www.hassellinclusion.com/blog/should-accessible-websites-still-support-ie11/. I don't know if it's out of date, there's no publication date but there are comments from January 2021 so it's possible the information is still valid.

fgomez828 commented 1 year ago

per the notice at the top of the Micorosoft FAQ on this topic this page, it sounds like we might be able to stop supporting IE this summer? I'm not 100% sure what other considerations there are besides general availability of the app on Windows.

Here's the highlighted text at the top of the page:

Update: The retired, out-of-support Internet Explorer 11 desktop application has been permanently disabled through a Microsoft Edge update on certain versions of Windows 10.

IE11 visual references, such as the IE11 icons on the Start Menu and taskbar, will be removed by the June 2023 Windows security update (“B” release) scheduled for June 13, 2023.

smcalilly commented 1 year ago

@fatima3558 is making good progress on this.

smcalilly commented 1 year ago

See: https://gs.statcounter.com/browser-market-share/all/united-states-of-america

IE has 0.24% of market share in March 2023.

We're okay with upgrading to Bootstrap 5.

IE support could be something we decide upon with a client beforehand.