datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
80 stars 12 forks source link

in the directions for setting up heroku for a legacy app, it says we use github actions for deploying to heroku, but we don't? #335

Closed fgregg closed 12 months ago

fgregg commented 1 year ago

https://github.com/datamade/how-to/blob/86d040516e55f336adaef72d653c8fc15d7f7b80/deployment/heroku/deploy-a-django-app.md#set-up-github-actions-for-ci

Set up GitHub Actions for CI

For Heroku deployments, we use GitHub Actions for CI (continuous integration). Read the how-to to set up GitHub Actions.

I don't think this is actually our practice, and clicking through the link doesn't reference heroku at all?

hancush commented 12 months ago

We check a box in the Heroku UI that says wait for CI to pass, which relies on having GitHub Actions set up. https://github.com/datamade/how-to/blob/86d040516e55f336adaef72d653c8fc15d7f7b80/deployment/heroku/deploy-a-django-app.md#configure-deployments-from-git-branches

fgregg commented 12 months ago

got it.