Add templates for containerizing Python web applications

datamade / how-to

📚 Doing all sorts of things, the DataMade way

MIT License

87 stars 12 forks source link

Add templates for containerizing Python web applications #47

Closed hancush closed 4 years ago

hancush commented 4 years ago

Overview

This pull request templates the Dockerfile, docker-compose.yml, and tests/docker-compose.yml recommended in our documentation for containerization for local development.

Closes #41

Testing Instructions

Select a Django web application.
Follow the instructions in docker/templates/README.md to generate containerization artifacts for your application.
Build and run your newly containerized application, and confirm that it runs as expected.
View the rendered markdown for local development and the templates README, and confirm that links work and the formatting looks nice.

jeancochrane commented 4 years ago

Excited to give this a spin! I'll take a look during my R&D day this coming Friday.

hancush commented 4 years ago

FWIW, I used these templates to containerize NOF! https://github.com/datamade/neighborhood-fund/pull/32

It took about five minutes. 🎊

hancush commented 4 years ago

-v pwd:pwd -w pwd is huge, @jeancochrane! had no idea about that trick. def prefer it here, will update. thank you!

jeancochrane commented 4 years ago

Don't thank me, thank the Docker docs! https://docs.docker.com/engine/reference/commandline/run/#mount-volume--v---read-only

hancush commented 4 years ago

thanks very much for the thoughtful review, @jeancochrane! i believe i've accounted for all of your comments – let me know if i've missed anything. :-)

hancush commented 4 years ago

This has been really instructive. Thanks, @jeancochrane!