datamade / how-to

📚 Doing all sorts of things, the DataMade way
MIT License
86 stars 12 forks source link

Gatsby cookiecutter template #85

Closed beamalsky closed 3 years ago

beamalsky commented 4 years ago

Overview

This PR adds a cookiecutter template for a DataMade-style Gatsby app to docker/templates. It's based on gatsby-starter-default but includes Bootstrap setup, a Github Action for linting, and is containerized.

@jeancochrane or @hancush, I'd love to hear your thoughts on the containerization here. When I'm developing a Gatsby project and add or delete a dependency, I have to stop and rebuild the container. Is there a way I can modify my Dockerfile here so that it live updates node_modules?

Testing

beamalsky commented 3 years ago

Thanks @hancush! I've added edits based on your comments. After a little investigative work I believe that the Jinja error you noted above was caused by the double brackets of JSX syntax, eg:

  <header
    style={{
      background: `#e49fb2`,
      marginBottom: `1.45rem`,
    }}
  />

An unfortunate collision, but I've gotten around it by adding a line in cookiecutter.json to avoid rendering the culprit files, as this comment recommends: https://stackoverflow.com/a/39151217

beamalsky commented 3 years ago

@hancush I've set this up with a global styles sheet! Let me know if this looks good to merge. I'll open a PR now in testing guidelines