datamade / just-spaces

🏕 A tool from University City District and DataMade to promote better and more just public spaces
https://justspacesproject.org
MIT License
7 stars 1 forks source link

Chart colors #191

Closed beamalsky closed 5 years ago

beamalsky commented 5 years ago

Overview

This PR fixes the bug described in #188: ACS charts can choose the same color as primary_source.

To get around this, I set primary source to a consistent color ("Just Spaces mid-green"), and give the ACS series a set of colors to choose from. These can't repeat, as ACS series are torn down and recreated whenever they change. I think this also has the advantage of consistently visually distinguishing collected data from ACS data. If this project is extended to handle multiple series of collected data on the same chart this will have to be updated, but my understanding is that that's not on the horizon for the current scope.

In the process I've also added a color palette for the charts to bring it more in line with the rest of the site and away from the HighCharts defaults!

It should look like this:

Screen Shot 2019-07-02 at 4 14 16 PM

This also modifies before_install.sh to handle blackbox being updated on the server, as documented at https://github.com/datamade/deploy-a-site/pull/69

Closes #188

Testing Instructions