Add ability to redact name and address from donor records

datamade / openness-project-nmid

Money Trail NM - New Mexico In Depth's Campaign Finance Explorer

https://moneytrailnm.com

3 stars 1 forks source link

Add ability to redact name and address from donor records #179

Closed hancush closed 8 months ago

hancush commented 9 months ago

Overview

See title. Redacting information from one contribution record will also redact other contributions from the same donor.

Only authenticated users can redact records.

Redacted records should appear as redacted on candidate and committee detail pages, as well as in contribution exports. They should also be excluded from site search results.

Demo

Testing Instructions

View a contribution and confirm you don't see the redaction form.
Create a super user on the deploy preview and log in.
Navigate to a contribution and confirm you can see the redaction form.
Redact the record.
Navigate to the detail page of the recipient, and confirm the donor's details are redacted.
Unredact the record.
Navigate to the detail page of the recipient, and confirm the donor's detail are not redacted.

hancush commented 8 months ago

Changes in. Can you have another pass?

hancush commented 8 months ago

@derekeder Can you hard refresh after you redact/unredact? It's working fine on Chrome – what browser are you in?

redact

hancush commented 8 months ago

Also, Top 25 donors looks buggy indeed. Would you mind if I looked at that separately?

derekeder commented 8 months ago

huh weird. im in firefox and just tried in chrome and it works. here's me editing the same record in both browsers:

https://github.com/datamade/openness-project-nmid/assets/919583/dbe8dede-bf3a-4a60-b4d6-c6adb4ad8b08

hancush commented 8 months ago

Can you disable your ad blockers and try again? It's working on fresh Firefox install for me:

redact-ff

hancush commented 8 months ago

Also, @derekeder, just pushed a change fixing top donors! Nvm about addressing separately.

derekeder commented 8 months ago

got an error when trying to redact this donation: https://openness-pro-hcg-redact-ehwzmc.herokuapp.com/contributions/1428368/

https://github.com/datamade/openness-project-nmid/assets/919583/4933a98b-22cc-4c43-966a-92946ffafd19

redaction name still showing up on the Top 25 page after redacting, though it shows up as redacted on 'All donations':

hancush commented 8 months ago

@derekeder Damn, this data is so messy! Just pushed up a patch, try again when it's done deploying.