search

datamapper / dm-aggregates

DataMapper plugin providing support for aggregates on collections
http://datamapper.org/
MIT License
16 stars 15 forks source link

aggregate function count broken for queries with :limit #7

Open solnic opened 13 years ago

solnic commented 13 years ago

This is related to the problem and fix posted over a year ago:

 http://groups.google.com/group/datamapper/browse_thread/thread/503cfb37c9ca23e5/3031713f309910b1?lnk=gst&q=size+count#3031713f309910b1

dkubb commented out the optimization of size calling count 

 http://github.com/datamapper/dm-more/commit/35ac591458ba477c875b3541f0b419a2c06f00e7

to use Array#size to properly recognize :limit in the query.

If size recognizes :limit in the query, shouldn't count also?

For instance, dm-pager assumes this of count and breaks on queries with :limit:

 http://github.com/visionmedia/dm-pagination/blob/master/lib/dm-pager/pagination.rb

 options.merge! :total => count(query), :page => page

(The root cause is probably do_mysql adapter not translating the query correctly.)

Created by Ming - 2010-02-24 20:34:11 UTC

Original Lighthouse ticket: http://datamapper.lighthouseapp.com/projects/20609/tickets/1203

solnic commented 13 years ago

See #1416

by Martin Gamsjaeger (snusnu)

solnic commented 13 years ago

(from [1f9b8bf0d97a2458b9721e5fa02a7f1f69fdcdf3]) Add failing spec for #count called on a limited collection

[#1334 state:confirmed] [#1203 state:confirmed] [#1416 state:confirmed] http://github.com/datamapper/dm-aggregates/commit/1f9b8bf0d97a2458b9721e5fa02a7f1f69fdcdf3

by Dan Kubb (dkubb)

solnic commented 13 years ago

(from [0b2afc96e4917e868853f3c9ddcc5c8f31ba58e5]) Mark #count on a limited collection spec as pending

[#1334 state:confirmed] [#1203 state:confirmed] [#1416 state:confirmed] http://github.com/datamapper/dm-aggregates/commit/0b2afc96e4917e868853f3c9ddcc5c8f31ba58e5

by Dan Kubb (dkubb)

solnic commented 13 years ago

[bulk edit]

by Dan Kubb (dkubb)