dm-serializer redefines the global CSV constant on Ruby 1.8

[rsutphin]

dm-serializer/to_csv.rb redefines the global CSV constant to be an alias to FasterCSV when running under Ruby 1.8. While I understand the desire to keep the remainder of the code the same under 1.8 and 1.9, this causes two problems:

• If the built-in CSV library has already been required when dm-serializer is loaded, you get a constant redefinition warning.
• If the built-in CSV library is required after dm-serializer (e.g., by another library) you get a superclass mismatch for class Row error.

An alternative: define a method on DataMapper::Serializer that returns the appropriate module to use (CSV or FasterCSV) depending on the ruby version.

[hhuang]

+1

[glennr]

+1

[rue0815]

+1

[tpitale]

Does anyone still need this? Ruby 1.8 (and 1.9 for that matter) are unsupported any longer. I'm not sure we have the people to maintain support for these versions. If you are still using 1.8 please leave a comment and I'll reopen.