Closed emmanuel closed 13 years ago
@emmanuel I think we agreed that it's not gonna be merged in. so if you don't mind, I will close it, ok?
We did agree that this was not the right direction to go: adding Resource lifecycle responsibilities to Property introduces more coupling. I think something like (my interceptors spike)[https://github.com/emmanuel/dm-core/compare/datamapper:master...emmanuel:feature/interceptors] will be a better direction instead.
Go ahead and close this.
On Sep 14, 2011, at 2:13 AM, Piotr Solnica wrote:
@emmanuel I think we agreed that it's not gonna be merged in. so if you don't mind, I will close it, ok?
Reply to this email directly or view it on GitHub: https://github.com/datamapper/dm-types/pull/32#issuecomment-2091263
This is the third of 3 pull requests from decomposing the many changes in #24. It is a superset of the changes in #30 and #31.
These changes subsume dm-timestamps into dm-types and unify the naming of Paranoid* to align with the naming. This results in:
:created_on
->Created::Date
:created_at
->Created::DateTime
:updated_on
->Updated::Date
:updated_at
->Updated::DateTime
ParanoidBoolean
->Destroyed::Boolean
ParanoidDateTime
->Destroyed::DateTime
I haven't ported the
Model#timestamps
macro fromdm-timestamps
(labeled as implicit property declaration in thedm-timestamps
specs). My thinking is that if these changes (#30, #31 and this) are integrated, theModel#timestamps
macro may remain in an updateddm-timestamps
gem which merely provides a dependency ondm-types
and a method or two for backwards compatibility.