search

datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

bcrypt-ruby update #47

Closed swills closed 13 years ago

swills commented 13 years ago

Hi,

Could you loosen the version requirements to work with bcrypt-ruby 3.0.0 or greater? Since bcrypt-ruby3.0.1 is out this would make packaging dm-types 1.2.0 for FreeBSD possible.

Steve

dkubb commented 13 years ago

Hi Steve,

Could you loosen the version requirements to work with bcrypt-ruby 3.0.0 or greater? Since bcrypt-ruby3.0.1 is out this would make packaging dm-types 1.2.0 for FreeBSD possible.

Sure. We're in the middle of an RC series, but the next release (1.2.0) will allow for bcrypt-ruby 3.0.0, see:

https://rubygems.org/gems/dm-types/versions/1.2.0.rc2

We may tweak it to ~> 3.0.1 or whatever the latest is at the time of the next rc/final which should be coming within the next few days.

Dan

swills commented 13 years ago

Hi,

Thanks! I'm aware 1.2 is coming out soon and having bcrypt-ruby 3.0.1 as the dependency there would be great.

One thing of note: With the packaging we use, it doesn't support or allow more than one version of a package at a time, so having the depends more flexible, so that any bcrypt-ruby 3.0.x is acceptable, would make it easier for us long term when new versions of bcrypt-ruby come out. Of course, I can understand that gem doesn't have that restriction and if changing to that type of dependency isn't something you're comfortable with I completely understand.

BTW, when do you think 1.2.0 will be out? I'm currently holding back the update of bcrypt-ruby to 3.0.x since the current version of dm-types doesn't support it.

Thanks, Steve

solnic commented 13 years ago

@swills the dep on bcrypt is set to ~> 3.0.0 so every 3.0.x will work

Regarding final release of 1.2.0 - I think there won't be rc3 which means that we should be ready to push 1.2.0 final later next week

swills commented 13 years ago

Ah, great, thanks!