search

datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

Use multi_json 1.2.0 #54

Closed tomykaira closed 12 years ago

tomykaira commented 12 years ago

Version of multi_json is too old.

I run the spec with 1.2.0, and all the active spec passed (in ruby 1.9.2).

solnic commented 12 years ago

thanks man

carlosacp commented 12 years ago

Hello, Solnic! Now I'm having problems with gem dependence between dm-serialize and dm-types:

Bundler could not find compatible versions for gem "multi_json": In Gemfile: dm-serializer (>= 0) ruby depends on multi_json (~> 1.0.3) ruby

dm-types (>= 0) ruby depends on
  multi_json (1.2.0)
solnic commented 12 years ago

@carlosacp is there any specific reason you used 1.2.x? I can see that the latest version of multi_json is 1.3.2. I'd prefer to bump the dep to the latest version.

carlosacp commented 12 years ago

Hello, Solnic!

I can update multi_json to 1.3.X with no problem. But I think the problem is between dm-types and dm-serialize. I removed dm-serialize dependency and bundle works fine.

Just so you know, I'm using the 1.3.0 beta (head commit), rails 3.2.1, carrierwave (0.5-stable) and carrierwave-datamapper

solnic commented 12 years ago

@carlosacp that's because both dm-types and dm-serializer depend on multi_json and we only bumped it here :)

carlosacp commented 12 years ago

:) Will It be bumped in the other plugins too?

solnic commented 12 years ago

@carlosacp yes. in fact both were already bumped.

carlosacp commented 12 years ago

Thank you, Solnic! I'm going to update everything for latest commit!