search

datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

Updating multi_json, & stringext dependencies to be more modern. #65

Closed nmccready closed 8 years ago

nmccready commented 11 years ago

updating dependencies for multi_json, and stringsext. All specs pass. This is a must for locomotivecms compatibility.

dkubb commented 11 years ago

@nmccready I noticed that the latest stringex is 2.0.8, was there any reason you used 2.0.3 instead?

nmccready commented 11 years ago

@dkubb yes my goal was to make it compatible with this https://github.com/locomotivecms/engine/blob/master/locomotive_cms.gemspec

I will see if 2.0.8 works and if so I will post back with the update. I assume if I patch this on the 1.2.* branch that it might help with locomotivecms as well.

nmccready commented 11 years ago

Donezo

nmccready commented 11 years ago

I'm trying to see if this is possible to update in the release 1.2 branch. Anyways I keep getting the following error on rspec.

rspec-1.3.2/lib/spec/runner/options.rb:188: Use RbConfig instead of obsolete and deprecated Config.
NameError: uninitialized constant DataMapper::Property::BCryptHash::PassThroughLoadDump

https://github.com/datamapper/dm-types/issues/66

nmccready commented 11 years ago

Any updates on this? If I can use 1.2 instead that would be preferable as I do not see 1.3.0 being released anytime soon. So any help with the 1.2 branch is much appreciated.

dkubb commented 11 years ago

@nmccready are you using dm-core with dm-types all with the 1.2.x versions? You cannot mix and match versions of gems, a 1.3.0 will likely not work with 1.2.x.

dkubb commented 11 years ago

To run the specs for dm-types in the release-1.2 branch you'd use:

git checkout release-1.2

GIT_BRANCH=release-1.2 bundle
GIT_BRANCH=release-1.2 bundle exec rake spec
nmccready commented 11 years ago

I ran the tests with the command above and they passed.

Finished in 5.568 seconds

300 examples, 0 failures, 3 pending
nmccready commented 10 years ago

@dkubb whats the hold up?

tpitale commented 8 years ago

@nmccready If you could update this against master, I will try to get it merged for 1.3.0.

nmccready commented 8 years ago

I'll pull it down and merge, hopefully it still works. I haven't touched this stuff in forever.

tpitale commented 8 years ago

@nmccready Thanks! I know this has been dead for a long time. Trying to tackle a little at a time. Appreciate you taking a look.

nmccready commented 8 years ago

merged

nmccready commented 8 years ago

You might want to add a .travis.yml file to test in the cloud

nmccready commented 8 years ago

Do I need to drop the versions down any on stringex?

tpitale commented 8 years ago

Thanks! Yeah, getting all the projects on Travis is one of my tasks. We have inconsistent coverage there. :smile:

I think the version of stringex is fine for now. Latest is 2.6.0, so folks can upgrade if they'd like to.