search

datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

Update safe_yaml to latest stable #68

Closed DavidAllison closed 9 years ago

DavidAllison commented 11 years ago

This is the simplest way I could see to make this change (though I've noted that in dm_types master branch safe_yaml is actually gone, so if it's preferable to just remove the requirement let me know).

I found that running bundle on the branch fails due to dm-migrations not being found, but this issue pre-exists this change.

It looks like this, for reference:

Fetching gem metadata from http://rubygems.org/.........
Fetching gem metadata from http://rubygems.org/..
Resolving dependencies...
Could not find gem 'dm-migrations (~> 1.2.0) ruby' in http://github.com/datamapper/dm-migrations.git (at master).
Source contains 'dm-migrations' at: 1.3.0.beta
DavidAllison commented 10 years ago

@dkubb Not sure if you saw the note above - I think this PR's single line change couldn't have an effect on whether dm-migrations can be found, since all it does is upgrade safe_yaml. Any thoughts?

DavidAllison commented 10 years ago

@dkubb Any chance you might be able to take a look at the one line PR above?

tpitale commented 9 years ago

@DavidAllison It appears as though the safe_yaml conflicts with other dependencies: https://travis-ci.org/datamapper/dm-types/jobs/13220738 in the case of dm-yaml-adapter. Any thoughts on resolving that?