search

datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

brcypt-ruby name change #70

Closed rupe closed 8 years ago

rupe commented 10 years ago

Update the 'bcrypt-ruby' gem requirement to just 'bcrypt', as the gems name has been changed and requiring the former results in an informational messages being displayed.

Choms commented 9 years ago

+1

Fusl commented 9 years ago

There is already a pull request open since August: https://github.com/datamapper/dm-types/pull/73 I don't think that anyone will merge this ever.

postmodern commented 9 years ago

It turns out I have commit rights to this repo. The change appears trivial enough, I could pull it in. Travis CI only errored out on ruby-head and jruby-head. Perhaps those should be allowed to fail?

tpitale commented 8 years ago

This is fixed on master afaict.

Choms commented 8 years ago

Hi, Would you mind issuing a new release so when we require this gem we don't get that error message anymore? Even though is fixed on master, the latest gem (dm-types 1.2.2) is still requiring bcrypt-ruby. Thanks!

tpitale commented 8 years ago

Many things have to happen across all the DM repos before we can release new gems. Nobody seems willing to help maintain, so that seems unlikely to happen.

Bundler supports using git repos quite easily. Please help by testing that and letting us know if that fixes the issue @Choms.