datamapper / dm-types

DataMapper plugin providing extra data types
http://datamapper.org/
MIT License
55 stars 80 forks source link

Loosen dependency on multi_json #85

Closed basex closed 8 years ago

basex commented 8 years ago

The other datamapper gems depend mostly on multi_json 1.3.2 Example: https://github.com/datamapper/dm-serializer/blob/master/dm-serializer.gemspec

dm-types also depended previously on 1.3.2 https://github.com/datamapper/dm-types/commit/e541869dc05fdd707e8242ec8922873f75e50fc2

tpitale commented 8 years ago

After I merge this https://github.com/datamapper/dm-types/pull/86 can you rebase/squash and push this PR again so that it runs in CI (now that I enabled PR runs again)?

basex commented 8 years ago

yes I can do that, I also relaxed the multi_json dependency on dm-serializer https://github.com/datamapper/dm-serializer/pull/46

tpitale commented 8 years ago

Go for a rebase, I just merged the fix into master. Thanks @basex!

basex commented 8 years ago

Sorry tpitale, there is not really a need to decrease this gem dm-types version required. The problem is with dm-serializer. I will rebase or create a new PR there.