do_jdbc: Change DataObject::Command#debug to call DataObject::Connection#log

datamapper / do

DataObjects

147 stars 74 forks source link

do_jdbc: Change DataObject::Command#debug to call DataObject::Connection#log #12

Closed hryk closed 13 years ago

hryk commented 13 years ago

This commit fixes do_jdbc's debug method. In the case of do_mysql, "data_objects_debug" function use DataObject::Connection#log to output debug log. But do_jdbc's "debug" method use driverModule's logger. Because of this difference, dm-rails could not send notification to LogSubscriber when using JRuby and do_jdbc.

pietia commented 13 years ago

@myabc, you were faster :D

myabc commented 13 years ago

@pietia Always am!

On Jun 23, 2011, at 3:21 PM, pietia wrote:

@myabc, you were faster :D

Reply to this email directly or view it on GitHub: https://github.com/datamapper/do/pull/12#issuecomment-1425142

mkristian commented 13 years ago

@myabc took you 3 hours - I will go for race next time too ;-)

hryk commented 13 years ago

@myabc Thank you for quick merge! btw, I found do_mysql's duration is microseconds, not milliseconds. Could you merge this commit If it correct ?