datamapper / do

DataObjects
147 stars 74 forks source link

Fix spec_helper scoping in derby, h2, hsqldb #26

Closed abevoelker closed 12 years ago

abevoelker commented 12 years ago

I am writing an adapter for a new database and am basing it off of Derby. I noticed that the scoping of the 1..upto(16) block in the spec_helper seems to be off (conn.close is in the loop scope). Hopefully I'm not missing something here, as the Derby specs seem to pass either way.

mkristian commented 12 years ago

the con.close having no effect on the remaining part of the loop (before the patch) is a bit scary.

thanx for patch