search

datamapper / do

DataObjects
147 stars 74 forks source link

Switch default values to UTC, and add sub-second values #80

Open tpitale opened 9 years ago

tpitale commented 9 years ago

First pass, we probably need more specs in different timezones, and more structure between Time and DateTime.

Please let me know what you think @dbussink. This is passing when I run bundle exec rake spec from within do_postgres.

tpitale commented 9 years ago

This relates to both #78 and #79.

tpitale commented 9 years ago

Hrm. TravisCI appears to be randomly killing the build after that last push.

dbussink commented 9 years ago

@tpitale What do you mean with killing the build?

tpitale commented 9 years ago

The builds stopped at random places, and the last thing in the log is: 'The build has been terminated'. https://travis-ci.org/datamapper/do/jobs/54308706#L573

dbussink commented 9 years ago

@tpitale I suspect something might be broken then that causes it to hang indefinitely and then Travis aborts it. I suspect it's a problem with the changes, not with Travis. Might have some time tomorrow to run this and see if there's anything standing out.

tpitale commented 9 years ago

Yeah, the specs stalled for me locally after that change. I'll dig in when I get home tonight. I had to reinstall my MySQL.

tpitale commented 9 years ago

Okay, I reverted that change from yesterday. Now I'm trying to figure out how to get mysql to work in UTC. It's just insanity.

tpitale commented 9 years ago

I don't think it's possible for mysql to share specs with postgresql and use a time zone other than local system time.