search

datamapper / do

DataObjects
147 stars 74 forks source link

Postgres bignum insert #99

Closed tpitale closed 8 years ago

tpitale commented 8 years ago

Replace all usage of INT2NUM(atoi(cstr)) inside do_postgres with rb_cstr_to_inum.

Resolves #98.

dbussink commented 8 years ago

This might also apply to the other drivers, so would be good to review those too.

dbussink commented 8 years ago

Looks like MySQL's logic uses it's internal my_ulonglong type and that should be fine.

There are 2 more cases of atoi though in the Postgres driver for the number of affected rows. Those should also be updated then.

tpitale commented 8 years ago

Okay, replaced all those uses of atoi. Now, we wait (for Travis). I may need to debug why CI is failing, because I'm not sure what triggered the failures.

tpitale commented 8 years ago

Okay … I think we have to drop support for 1.8.7, ree, and 1.9.2. Travis CI has, at least.

dbussink commented 8 years ago

@tpitale Yeah, you can move 1.9.2 to the allowed failures here to get the branch green?

tpitale commented 8 years ago

@dbussink This looks good to merge. I can do that if you wouldn't mind releasing a gem version. Thanks for all your help!

tpitale commented 8 years ago

Okay, re-running this now that I restored 1.9.3 to CI.

tpitale commented 8 years ago

All green!