datamintsGmbH / datamints_locallang_builder

Offers developers and editors a backend module for creating, changing and translating language files for your extensions. Significant improvement of the workflow by using an independent translation provider such as Azure, DeepL or Google Translate.
https://www.datamints.com
Other
4 stars 5 forks source link

if !is_dir instead of if !is_file #4

Closed dbunkerd closed 3 years ago

dbunkerd commented 3 years ago

I could get the export function to work only after I edited ExportService.php line 87

if(!is_file(GeneralUtility::getFileAbsFileName($customPath))) {
            \mkdir(GeneralUtility::getFileAbsFileName($customPath));
        }

to

if(!is_dir(GeneralUtility::getFileAbsFileName($customPath))) {
            \mkdir(GeneralUtility::getFileAbsFileName($customPath));
        }

The same seems to be true for BackupService.php

Kind regards

weisgerberm commented 3 years ago

Thanks for your report.

I fixed this in Version 1.0.10. Strangely, it also worked with "is_file" on our system, but "is_dir" makes more sense ;)

Kind regards