datamllab / rlcard

Reinforcement Learning / AI Bots in Card (Poker) Games - Blackjack, Leduc, Texas, DouDizhu, Mahjong, UNO.
http://www.rlcard.org
MIT License
2.85k stars 614 forks source link

Kuhn poker implementation #171

Open cfytrok opened 3 years ago

cfytrok commented 3 years ago

I want to implement Kuhn poker and create pull request. The documentation says that I have to inherit from classes in rlcard/core.py. However, Leduc poker is implemented by inheriting from limit poker classes. It looks like the limit poker classes are the base class for other games. I want to implement kuhn poker for an arbitrary number of players, but it seems the limit poker implementation only supports 2 players. How to do it better?

daochenzha commented 3 years ago

@cfytrok I think both will work. We implemented Leduc poker by inheriting from limit poker classes because those pokers have similar rules. Inheriting limit poker classes saves efforts.