hadim commented 2 years ago

Checklist:

[ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added or an existing one is deleted.
[x] Added a news entry.
- copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

MichelML commented 2 years ago

I guess the failing tests is expected at the moment, seems unrelated.

hadim commented 2 years ago

I guess the failing tests is expected at the moment, seems unrelated.

Yup a boring regression on the Github action we use. Will fix before merging.

Thanks guys.

hadim commented 2 years ago

GA bug being addressed at https://github.com/mamba-org/provision-with-micromamba/issues/54

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (6ebf205) into main (a4b7cc1) will decrease coverage by 0.03%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   83.77%   83.73%   -0.04%     
==========================================
  Files          48       48              
  Lines        3420     3425       +5     
==========================================
+ Hits         2865     2868       +3     
- Misses        555      557       +2

Flag	Coverage Δ
unittests	`83.73% <75.00%> (-0.04%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
datamol/descriptors/descriptors.py	`94.02% <75.00%> (-2.75%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4b7cc1...6ebf205. Read the comment docs.

datamol-io / datamol

dont import sasscorer by default #102

Codecov Report