datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
462 stars 48 forks source link

Molblock + other things #106

Closed hadim closed 2 years ago

hadim commented 2 years ago

Checklist:


codecov[bot] commented 2 years ago

Codecov Report

Merging #106 (28e1e4e) into main (edbe94d) will increase coverage by 0.03%. The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   83.80%   83.84%   +0.03%     
==========================================
  Files          48       48              
  Lines        3452     3472      +20     
==========================================
+ Hits         2893     2911      +18     
- Misses        559      561       +2     
Flag Coverage Δ
unittests 83.84% <95.23%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/io.py 89.79% <94.44%> (+0.90%) :arrow_up:
datamol/__init__.py 100.00% <100.00%> (ø)
datamol/viz/utils.py 80.00% <0.00%> (-6.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edbe94d...28e1e4e. Read the comment docs.

hadim commented 2 years ago

Should we time with the mdl issue in outlines ?

I am fine with both: merging and iterating fast or holding here as the features in that PR are not super urgent.

hadim commented 2 years ago

@maclandrol what about #105?

maclandrol commented 2 years ago

@hadim , we can close #105, I forgot about the fact we had it already. Was looking into the scaffold module

hadim commented 2 years ago

Ok thanks. Then I'll merge here and we can iterate further if we need to modify the molblock logic.