datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
462 stars 48 forks source link

Reations #143

Closed zhu0619 closed 2 years ago

zhu0619 commented 2 years ago

Checklist:


codecov[bot] commented 2 years ago

Codecov Report

Merging #143 (dbcd57a) into main (57d2db2) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head dbcd57a differs from pull request most recent head fd2c6ad. Consider uploading reports for the commit fd2c6ad to get more accurate results

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   91.17%   91.20%   +0.02%     
==========================================
  Files          46       46              
  Lines        3208     3218      +10     
==========================================
+ Hits         2925     2935      +10     
  Misses        283      283              
Flag Coverage Δ
unittests 91.20% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/reactions/_reactions.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhu0619 commented 2 years ago

@maclandrol This PR is for adding the argument for the product index as you raised in the last PR.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB