datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
462 stars 48 forks source link

compat with newest rdkit #145

Closed hadim closed 1 year ago

hadim commented 1 year ago

Checklist:


review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 1 year ago

Codecov Report

Merging #145 (531d908) into main (734f054) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   91.20%   91.26%   +0.05%     
==========================================
  Files          46       46              
  Lines        3218     3239      +21     
==========================================
+ Hits         2935     2956      +21     
  Misses        283      283              
Flag Coverage Δ
unittests 91.26% <100.00%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/convert.py 92.77% <100.00%> (+0.04%) :arrow_up:
datamol/mol.py 96.80% <100.00%> (+0.11%) :arrow_up:
datamol/types.py 100.00% <100.00%> (ø)
datamol/viz/utils.py 82.35% <100.00%> (+2.35%) :arrow_up:
datamol/utils/jobs.py 97.41% <0.00%> (+0.02%) :arrow_up:
datamol/utils/fs.py 88.02% <0.00%> (+0.07%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more