datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
452 stars 47 forks source link

Consistent image output #179

Closed hadim closed 1 year ago

hadim commented 1 year ago

Checklist:


codecov[bot] commented 1 year ago

Codecov Report

Merging #179 (d4ffa75) into main (b978fc5) will increase coverage by 0.01%. The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   91.01%   91.02%   +0.01%     
==========================================
  Files          48       48              
  Lines        3785     3801      +16     
==========================================
+ Hits         3445     3460      +15     
- Misses        340      341       +1     
Flag Coverage Δ
unittests 91.02% <93.93%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/viz/utils.py 87.17% <91.30%> (+4.82%) :arrow_up:
datamol/viz/_lasso_highlight.py 90.82% <100.00%> (+0.19%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hadim commented 1 year ago

@cwognum @dessygil FYI I noticed a few mistakes we've made in the previous PR:

Nothing to do on your side and it's mostly FYI here.

hadim commented 1 year ago

Merging here as I don't think the failing osx test is legit here. (will fix in main if needed).