datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
469 stars 51 forks source link

Rewrite dm.viz.circle_grid with RDKit's canvas and support grid image for lasso highlight #203

Closed maclandrol closed 1 year ago

maclandrol commented 1 year ago

Changelogs

Checklist:


This PR fixes #196 and #199

maclandrol commented 1 year ago

You can now do this efficiently:

circle_grid

codecov[bot] commented 1 year ago

Codecov Report

Merging #203 (16af43f) into main (9bea940) will increase coverage by 0.52%. The diff coverage is 92.19%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   91.48%   92.01%   +0.52%     
==========================================
  Files          46       46              
  Lines        3664     3781     +117     
==========================================
+ Hits         3352     3479     +127     
+ Misses        312      302      -10     
Flag Coverage Δ
unittests 92.01% <92.19%> (+0.52%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/convert.py 88.77% <ø> (-0.06%) :arrow_down:
datamol/viz/utils.py 88.23% <83.33%> (+3.61%) :arrow_up:
datamol/viz/_lasso_highlight.py 91.51% <91.74%> (+0.56%) :arrow_up:
datamol/viz/_circle_grid.py 92.81% <92.75%> (+14.10%) :arrow_up:
datamol/types.py 100.00% <100.00%> (ø)
datamol/viz/_viz.py 90.74% <100.00%> (+2.80%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more