datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
452 stars 47 forks source link

pass max_mols to Draw.MolsToGridImage #222

Closed kkovary closed 7 months ago

kkovary commented 8 months ago

Changelogs

closes #221

max_mols is passed to Draw.MolsToGridImage


Checklist:


discussion related to that PR

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4fbb047) 91.99% compared to head (ec2d34d) 92.33%.

Files Patch % Lines
datamol/viz/_viz.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== + Coverage 91.99% 92.33% +0.34% ========================================== Files 46 46 Lines 3873 3863 -10 ========================================== + Hits 3563 3567 +4 + Misses 310 296 -14 ``` | [Flag](https://app.codecov.io/gh/datamol-io/datamol/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datamol-io) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/datamol-io/datamol/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datamol-io) | `92.33% <94.44%> (+0.34%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datamol-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maclandrol commented 7 months ago

@kkovary, could you make the changes asked by @hadim in his last review ?

kkovary commented 7 months ago

just got back from a long vacation, I'll get on it ASAP!