Closed zhu0619 closed 4 months ago
Since it's still draft, I can wait.
The tests are failing, probably due to the different set arguments in the fingerprint generators. @maclandrol I need your help with revising default parameters. And I think the values in the tests for fingerprints need to be updated.
Since it's still draft, I can wait.
The tests are failing, probably due to the different set arguments in the fingerprint generators. @maclandrol I need your help with revising default parameters. And I think the values in the tests for fingerprints need to be updated.
Ok, will do.
@zhu0619, the default parameters were wrong. They are fixed now.
Still have to address this: https://github.com/danielfrg/mkdocs-jupyter/issues/200
Ideally in the next release, we should also have a minimum version for rdkit. As the pandas error still exists.
I also replaced seaborn by pure matplotllib in one of the notebook. Was getting an error and not sure how.
Feel free to merge anytime.
Changelogs
This PR addresses the fingerprint deprecation warnings, see issue #225.
ecfp-count
now use the ECFP-6, to stay consistent.dm.no_rdkit_log
which disable RDKit log for a whole function.Checklist:
feature
,fix
ortest
(or ask a maintainer to do it for you).The
rdFingerprintGenerator.GetCountFingerprint
can be used to compute the count based fingerprint. The argumentcountSimulation
indicates whether to compute the count fingerprint by bites simulation for computing efficiency. See more in this blog. I assume indatamol
, we want to compute the exact count-based fingerprint. Therefore,countSimulation
should be set to False.