hadim commented 2 years ago

Checklist:

[x] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added or an existing one is deleted.
[x] Added a news entry.
- copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

hadim commented 2 years ago

@maclandrol pinging you FYI but no need to review here as it's quite straightforward.

codecov[bot] commented 2 years ago

Codecov Report

Merging #80 (14d9330) into main (ea0bdf3) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   81.84%   81.83%   -0.02%     
==========================================
  Files          42       42              
  Lines        3041     3044       +3     
==========================================
+ Hits         2489     2491       +2     
- Misses        552      553       +1

Flag	Coverage Δ
unittests	`81.83% <100.00%> (-0.02%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
datamol/mol.py	`95.61% <100.00%> (+0.04%)`	:arrow_up:
datamol/viz/utils.py	`86.66% <0.00%> (-3.34%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea0bdf3...14d9330. Read the comment docs.

datamol-io / datamol

fix overflow in set_mol_props #80

Codecov Report