datamol-io / datamol

Molecular Processing Made Easy.
https://docs.datamol.io
Apache License 2.0
462 stars 48 forks source link

add esol descriptor #86

Closed hadim closed 2 years ago

hadim commented 2 years ago

Checklist:


codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (481c6dd) into main (c46f1e4) will increase coverage by 0.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   81.75%   82.08%   +0.32%     
==========================================
  Files          42       45       +3     
  Lines        3081     3137      +56     
==========================================
+ Hits         2519     2575      +56     
  Misses        562      562              
Flag Coverage Δ
unittests 82.08% <100.00%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/__init__.py 100.00% <100.00%> (ø)
datamol/descriptors/__init__.py 100.00% <100.00%> (ø)
datamol/descriptors/descriptors.py 100.00% <100.00%> (ø)
datamol/predictors/__init__.py 100.00% <100.00%> (ø)
datamol/predictors/esol.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46f1e4...481c6dd. Read the comment docs.

hadim commented 2 years ago

Thanks for the review.