datamol-io / graphium

Graphium: Scaling molecular GNNs to infinity.
https://graphium-docs.datamol.io/
Apache License 2.0
197 stars 12 forks source link

Reverting few changes #484

Closed WenkelF closed 11 months ago

WenkelF commented 11 months ago

Changelogs


Checklist:


discussion related to that PR

codecov[bot] commented 11 months ago

Codecov Report

Merging #484 (3f2b799) into main (e5fa686) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          93       93           
  Lines        8525     8525           
=======================================
  Hits         6088     6088           
  Misses       2437     2437           
Flag Coverage Δ
unittests 71.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)
DomInvivo commented 11 months ago

@kerstink-GC , can you check this PR?

DomInvivo commented 11 months ago

Please make sure that the change in default value is well documented