datamole-ai / edvart

An open-source Python library for Data Scientists & Data Analysts designed to simplify the exploratory data analysis process. Using Edvart, you can explore data sets and generate reports with minimal coding.
https://datamole-ai.github.io/edvart/
MIT License
48 stars 7 forks source link

Use dataclasses for section configuration #122

Closed lukany closed 1 year ago

lukany commented 1 year ago

Report classes contain a lot of duplicate code by duplicating section's parameters. E.g.: https://github.com/datamole-ai/edvart/blob/81570b154a415b31710336d91de2d2558757717e/edvart/report.py#L417-L430 https://github.com/datamole-ai/edvart/blob/81570b154a415b31710336d91de2d2558757717e/edvart/report_sections/bivariate_analysis.py#L82-L94

This could be avoided by creating dataclasses for section configuration.

Draft PR: #120

mbelak-dtml commented 1 year ago

Closing this issue. See https://github.com/datamole-ai/edvart/pull/120#issuecomment-1711410692