refactor!: remove parameter `df` from section constructors

datamole-ai / edvart

An open-source Python library for Data Scientists & Data Analysts designed to simplify the exploratory data analysis process. Using Edvart, you can explore data sets and generate reports with minimal coding.

https://datamole-ai.github.io/edvart/

MIT License

48 stars 7 forks source link

refactor!: remove parameter `df` from section constructors #141

Closed mbelak-dtml closed 1 year ago

mbelak-dtml commented 1 year ago

BREAKING CHANGE: Parameter df is removed from constructors of GroupAnalysis and UnivariateAnalysis.

mbelak-dtml commented 1 year ago

I'd use refactor! type and add BREAKING CHANGE footer.

Changed to refactor! and added the footer. Now that I think about it, is this still strictly a refactor if the behavior is slightly changed (GroupAnalysis constructor no longer raises when the parameter groupby contains an unknown column -- there is no way to check it now)? :thinking: I would keep it as a refactor anyway though, since it's breaking anyway and it's an edge case.