Closed mbelak-dtml closed 1 year ago
The static being methods inside the Section classes causes issues when exporting the code, such as having to alias the static methods for functions in "imports" (which in addition are not truly imports) e.g.: https://github.com/datamole-ai/edvart/blob/cfd61246845a435d384323c325a093e22f17e82e/edvart/report_sections/univariate_analysis.py#L297-L300 and having to modify the code in exported e.g. https://github.com/datamole-ai/edvart/blob/cfd61246845a435d384323c325a093e22f17e82e/edvart/report_sections/univariate_analysis.py#L345-L348
Section
Refactoring the static methods to module-level functions would simplify the code in these places.
Resolved by #142
The static being methods inside the
Section
classes causes issues when exporting the code, such as having to alias the static methods for functions in "imports" (which in addition are not truly imports) e.g.: https://github.com/datamole-ai/edvart/blob/cfd61246845a435d384323c325a093e22f17e82e/edvart/report_sections/univariate_analysis.py#L297-L300 and having to modify the code in exported e.g. https://github.com/datamole-ai/edvart/blob/cfd61246845a435d384323c325a093e22f17e82e/edvart/report_sections/univariate_analysis.py#L345-L348Refactoring the static methods to module-level functions would simplify the code in these places.