refactor: use instantiation

warcooft commented 4 months ago

See https://github.com/codeigniter4/CodeIgniter4/pull/9052#issuecomment-2241101064

Summary by CodeRabbit

New Features
- Improved instance management for the OAuth functionality, ensuring a fresh instance is used each time the allOAuth method is called.
- Enhanced clarity in the code by updating substring checks to use str_contains, improving readability.
Bug Fixes
- Enhanced reliability of the autoloading mechanism by preventing potential conflicts with pre-configured instances.

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent modifications in the codebase enhance the functionality and clarity of the ShieldOAuth and NewShieldOauthGenerator classes. The allOAuth method now creates a fresh instance of Autoload each time it is called, promoting better isolation. Additionally, the run method in the NewShieldOauthGenerator class replaces strpos with the more expressive str_contains, improving readability and aligning with modern PHP practices.

Changes

Files	Change Summary
`src/Libraries/Basic/ShieldOAuth.php`	In `allOAuth`, a new `Autoload` instance is created using `new Autoload()` instead of fetching a pre-configured instance, ensuring fresh instance usage.
`src/Commands/Generators/NewShieldOauthGenerator.php`	In `run`, `strpos` is replaced with `str_contains` to check for 'OAuth' in `$class`, enhancing readability while maintaining the same control flow.

Poem

In fields of code where bunnies play,
A change was made to brighten the day.
New instances hop, no strings attached,
Autoloads spring forth, perfectly matched.
With every call, fresh paths we find,
A leap towards clarity, oh so kind! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

datamweb commented 4 months ago

@coderabbitai Explain to the contributor that we currently support php version 7.4 so the use of command str_contains is not allowed.

Also, explain to the contributor that they should not use the merge command for a regular history of commits.

coderabbitai[bot] commented 4 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@warcooft:

Please note that our project currently supports PHP version 7.4. Therefore, the use of the str_contains function is not allowed, as it was introduced in PHP 8.0. You may need to revert to using strpos for compatibility.

Additionally, to maintain a clean and regular commit history, please avoid using the merge command for routine commits. Instead, consider using rebase or squash methods to keep the history linear and easier to follow.

Thank you for your understanding and cooperation.

datamweb / shield-oauth