fix: Prevent Duplicate Entry Errors

warcooft commented 1 month ago

Fixes: #173

Summary by CodeRabbit

New Features
- Enhanced error handling during user registration with specific messages for disabled accounts.
- Added new error messages in multiple languages (English, French, Indonesian, and Persian) for improved user feedback.
Bug Fixes
- Streamlined user ban checks to improve logic flow during authentication.

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@warcooft has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

📥 Commits
Files that changed from the base of the PR and between 1b88775d471f2c1bc5d5a088110ea72753061473 and 584c6164d74506ed6b6ea76ef1380989fe5cc827.

Walkthrough

The changes in this pull request focus on enhancing error handling and user management processes within the OAuthController class. Key modifications include the introduction of a try-catch block for user insertion to handle duplicate entries, a restructured user ban check, and updates to language files to provide clearer error messages for disabled accounts. These adjustments aim to improve the overall flow and robustness of user registration and authentication processes.

Changes

File Path	Change Summary
`src/Controllers/OAuthController.php`	- Added error handling for user insertion using `try-catch`. - Moved user ban check for better flow. - Updated method for user retrieval from `findById` to `find`.
`src/Language/en/ShieldOAuthLang.php`	- Added new entry `'account_disabled'` with a specific error message for disabled accounts.
`src/Language/fa/ShieldOAuthLang.php`	- Added new entry `'account_disabled'` with a placeholder for translation.
`src/Language/fr/ShieldOAuthLang.php`	- Added new entry `'account_disabled'` with a placeholder for translation.
`src/Language/id/ShieldOAuthLang.php`	- Added new entry `'account_disabled'` with a specific error message in Indonesian.

Assessment against linked issues

Objective	Addressed	Explanation
Handle soft-deleted users in OAuth login (Issue #173)	✅
Display notification for previously registered and deleted users (Issue #173)	❌	No notification mechanism implemented in changes.

Possibly related PRs

#167: This PR ensures that banned users are not allowed to log in, which directly relates to the changes in the main PR that manage user bans and improve error handling for banned users in the callBack method.
#169: This PR modifies the logic for checking if a user is banned, ensuring that the ban check is only applied to existing users, which aligns with the main PR's focus on user ban management in the callBack method.

Suggested labels

bug

Suggested reviewers

datamweb

Poem

In the land of OAuth, where users roam,
A rabbit brings changes, to make it feel home.
With messages clear, and bans in their place,
No more confusion, just a friendly embrace.
Hop along, dear users, your path is now bright,
For every account, we’ll handle with might! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

warcooft commented 1 month ago

Automated intervention by users can pose a security risk, especially if deletion decisions are made based on specific reasons known only to the admin.

In my opinion, this behavior should be able to be set through configuration, so that developers are more flexible in choosing and adapting this deletion behavior according to the needs of their use case.

datamweb / shield-oauth