search

datamweb / shield-oauth

OAuth for CodeIgniter Shield
https://www.shield-oauth.codeigniter4.ir/
MIT License
57 stars 16 forks source link

Fix Google OAuth login #31

Closed AlbertoMoricca closed 1 year ago

AlbertoMoricca commented 1 year ago

Applied the fixes on Google Oauth login discussed in the topic https://github.com/datamweb/shield-oauth/discussions/25

datamweb commented 1 year ago

@AlbertoMoricca Thank you very much for sending PR.

Your commits are not signed, please check here: https://github.com/codeigniter4/shield/pull/672#issuecomment-1468658726

AlbertoMoricca commented 1 year ago

Ok, I already added the key GPG key at the account but I miss the step of signing at commit (I thought that was automatic). I will submit another pull request with the commit signed.

datamweb commented 1 year ago

@AlbertoMoricca For automatic signature, see the description below:

https://github.com/codeigniter4/shield/pull/589#issuecomment-1377209525